Remove @executable_path/Frameworks from rpaths #7830
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @trybka |
sergiocampama
approved these changes
Mar 25, 2019
jin
added
the
z-team-Apple
|
@sergiocampama can you help land this one or should someone else verify it too? |
This is automatically added for these rule types by rules_apple. Having them here causes an issue with Xcode 10.2 and above because the /usr/bin/swift rpath _must_ be first, but this one is added first instead.
keith
force-pushed
the
ks/framework-rpath
branch
from
8d4d875
to
68d9eb4
Compare
dkelmer
pushed a commit
that referenced
this pull request
Apr 29, 2019
This is automatically added for these rule types by rules_apple. Having them here causes an issue with Xcode 10.2 and above because the /usr/bin/swift rpath _must_ be first, but this one is added first instead. Closes #7830. PiperOrigin-RevId: 240806623
This was referenced Apr 30, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is automatically added for these rule types by rules_apple. Having
them here causes an issue with Xcode 10.2 and above because the
/usr/bin/swift rpath must be first, but this one is added first
instead.